[webkit-reviews] review denied: [Bug 54870] [GStreamer] GRefPtr support for GstElement : [Attachment 83150] proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 54870: [GStreamer] GRefPtr support for GstElement
https://bugs.webkit.org/show_bug.cgi?id=54870

Attachment 83150: proposed patch
https://bugs.webkit.org/attachment.cgi?id=83150&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83150&action=review

> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:32
> +template <> void derefGPtr<GstElement>(GstElement* ptr)
> +{
> +    if (ptr)
> +	   gst_object_unref(ptr);
> +}

There should also be a specialization for refGPtr even if it's currently unused
with your changes. If that's not there g_object_ref will be used when you
assign a GRefPtr.