[webkit-reviews] review granted: [Bug 54676] Make ScriptElement match the HTML5 spec : [Attachment 83003] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 54676: Make ScriptElement match the HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=54676

Attachment 83003: Patch
https://bugs.webkit.org/attachment.cgi?id=83003&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83003&action=review

Looks great.  Thanks!

> Source/WebCore/dom/ScriptElement.cpp:222
> +    if
(!m_element->document()->contentSecurityPolicy()->canLoadExternalScriptFromSrc(
sourceUrl))
> +	   return false;

This is wrong, but that's my job to deal with, not yours.

> Source/WebCore/dom/ScriptElement.h:44
> +    bool prepareScript(const TextPosition1& scriptStartPosition =
TextPosition1::minimumPosition(), LegacyTypeSupport supportLegacyTypes =
DisallowLegacyTypeInTypeAttribute);

supportLegacyTypes parameter name isn't needed.