[webkit-reviews] review denied: [Bug 54688] ThreadableLoaderClient needs willSendRequest method. : [Attachment 83021] Proposed Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 54688: ThreadableLoaderClient needs willSendRequest method.
https://bugs.webkit.org/show_bug.cgi?id=54688

Attachment 83021: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=83021&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83021&action=review

Feel free to add ", 2011" to all of the Google copyright years in
DocumentThreadableLoader.cpp and ThreadableLoaderClient.h

r- for the changelog echo and the inverted if conditions.

> Source/WebCore/ChangeLog:21
> +2011-02-18  Bill Budge  <bbudge at chromium.org>

I sense an echo in here.

> Source/WebCore/loader/DocumentThreadableLoader.cpp:176
> +void DocumentThreadableLoader::willSendRequest(SubresourceLoader* loader,
ResourceRequest& newRequest, const ResourceResponse& redirectResponse)

I'm not sure why "request" became "newRequest".

It is the request that will be sent.

> Source/WebCore/loader/DocumentThreadableLoader.cpp:238
> +    if (!m_actualRequest)

This looks wrong.

m_actualRequest is only set while the preflight request is happening.

> Source/WebCore/loader/DocumentThreadableLoader.cpp:251
> +	   return;

Ditto.