[webkit-reviews] review requested: [Bug 53916] [Qt] WebKit patches required to work with a modularized version of Qt : [Attachment 82929] Avoided-UiTools-dependency-if-the-module-is-not-present-v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 18 00:29:54 PST 2011


Kristian Amlie <kristian.amlie at nokia.com> has asked  for review:
Bug 53916: [Qt] WebKit patches required to work with a modularized version of
Qt
https://bugs.webkit.org/show_bug.cgi?id=53916

Attachment 82929: Avoided-UiTools-dependency-if-the-module-is-not-present-v2
https://bugs.webkit.org/attachment.cgi?id=82929&action=review

------- Additional Comments from Kristian Amlie <kristian.amlie at nokia.com>
> Would the following work ? 

> -disable_uitools: DEFINES *= QT_NO_UITOOLS
> +contains(QT_CONFIG, modular):!contains(QT_CONFIG, uitools)|disable_uitools:
DEFINES *= QT_NO_UITOOLS

Yes, that should work.


More information about the webkit-reviews mailing list