[webkit-reviews] review denied: [Bug 51450] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows : [Attachment 82783] add more comments & make some changes according to others' comments

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Chun-Lung Huang
<alvincl.huang at gmail.com>'s request for review:
Bug 51450: Glyphs in vertical text tests are rotated 90 degrees clockwise on
Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=51450

Attachment 82783: add more comments & make some changes according to others'
comments
https://bugs.webkit.org/attachment.cgi?id=82783&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82783&action=review

Some comments for small issues.

> Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:620
> +	   updatedFamilyName = String(L"@") + String(family);

I think you don't need to do String(L"@").  Just '"@" + String(family)' should
work.

> Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp:82
> +    String newMName;

This should be "newName" because this variable is not a member of the class, so
m makes no sense.

> Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp:84
> +	   newMName = String(L"@") + m_name.charactersWithNullTermination();

.charactersWithNullTermination() is not needed here.  This should be just
'newName = "@" + m_name;'

> Source/WebCore/platform/graphics/skia/FontCustomPlatformData.cpp:86
> +	   newMName = m_name.charactersWithNullTermination();

.charactersWithNullTermination() is not needed.