[webkit-reviews] review requested: [Bug 51450] Glyphs in vertical text tests are rotated 90 degrees clockwise on Chromium Windows : [Attachment 82783] add more comments & make some changes according to others' comments

[bugzilla-daemon at webkit.org]

Chun-Lung Huang <alvincl.huang at gmail.com> has asked  for review:
Bug 51450: Glyphs in vertical text tests are rotated 90 degrees clockwise on
Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=51450

Attachment 82783: add more comments & make some changes according to others'
comments
https://bugs.webkit.org/attachment.cgi?id=82783&action=review

------- Additional Comments from Chun-Lung Huang <alvincl.huang at gmail.com>
(In reply to comment #9)
> I tried the patch locally, and found a renderer crashed at
ASSERT_NOT_REACHED() in FontCache::getLastResortFallbackFound()
FontCacheChromiumWin.cpp when I tried to load
fast/blockflow/Kusa-Makura-background-canvas.html.
(In reply to comment #11)
> yeah, I tried on Windows 7 English edition.

Hi all,

I saw Bono-san's patch for bug 52422.  It prevents the crash mentioned in
comments #9~#11 when my patch was applied.
So I just made a new patch according to others' comments.

Not perfect but it could get the basics working.  Please do consider that an
"@" can nearly do all the jobs.

Alvin