[webkit-reviews] review denied: [Bug 54446] Share the helper functions used by Latin-1 and UTF-8 text codecs : [Attachment 82435] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 15 08:53:59 PST 2011


Darin Adler <darin at apple.com> has denied  review:
Bug 54446: Share the helper functions used by Latin-1 and UTF-8 text codecs
https://bugs.webkit.org/show_bug.cgi?id=54446

Attachment 82435: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=82435&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82435&action=review

> Source/WebCore/platform/text/TextCodecHelpers.h:34
> +// Assuming that a pointer is the size of a "machine word", then
> +// uintptr_t is an integer type that is also a machine word.
> +typedef uintptr_t MachineWord;

Oops, this header needs to be in the WebCore namespace, not the global
namespace.


More information about the webkit-reviews mailing list