[webkit-reviews] review granted: [Bug 54446] Share the helper functions used by Latin-1 and UTF-8 text codecs : [Attachment 82435] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 54446: Share the helper functions used by Latin-1 and UTF-8 text codecs
https://bugs.webkit.org/show_bug.cgi?id=54446

Attachment 82435: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=82435&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82435&action=review

> Source/WebCore/ChangeLog:10
> +	   Move MachineWord, UCharByteFiller and the other helper functions
> +	   into TextCodecHelpers.h where they can be used by both TextCodecUTF8

> +	   and TextCodecLatin1.

Very good idea--I should have done this--but I do not like the name “helpers”
because it’s so vague.

I would call this TextCodecASCIIFastPath.h or something along those lines.

> Source/WebCore/platform/text/TextCodecLatin1.cpp:130
> +	   if (*source < 0x80) {

Should use isASCII instead of hardcoding 0x80.