[webkit-reviews] review denied: [Bug 54287] SubresourceLoader should expose finish time : [Attachment 82138] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 11 10:31:30 PST 2011
David Levin <levin at chromium.org> has denied Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 54287: SubresourceLoader should expose finish time
https://bugs.webkit.org/show_bug.cgi?id=54287
Attachment 82138: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=82138&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82138&action=review
Try uploading the patch with the fix for the item I noted and hopefully that
will fix the "pink" ews bubbles as well (which indicate that the patch doesn't
apply).
> Source/WebCore/ChangeLog:8
> + No new tests. (OOPS!)
Either explain why test aren't necessary, impossible, or add a test.
In this case "No new functionality exposed, so no new tests."
More information about the webkit-reviews
mailing list