[webkit-reviews] review denied: [Bug 13343] getComputedStyle returns wrong value for margin-right : [Attachment 82023] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 11 10:43:52 PST 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jarred Nicholls
<jarred.nicholls at gmail.com>'s request for review:
Bug 13343: getComputedStyle returns wrong value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=13343

Attachment 82023: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=82023&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=82023&action=review

> LayoutTests/fast/css/getComputedStyle/getComputedStyle-margin-auto.html:45
> +    document.write("width: " + window.getComputedStyle(foodiv,
null).getPropertyValue("width"));
> +    document.write( "<br>");
> +    document.write("height: " + window.getComputedStyle(foodiv,
null).getPropertyValue("height"));
> +    document.write( "<br>");
> +    document.write("margin-left: " + window.getComputedStyle(foodiv,
null).getPropertyValue("margin-left"));
> +    document.write( "<br>");
> +    document.write("margin-right: " + window.getComputedStyle(foodiv,
null).getPropertyValue("margin-right"));
> +    document.write( "<br>");
> +    document.write("margin-top: " + window.getComputedStyle(foodiv,
null).getPropertyValue("margin-top"));
> +    document.write( "<br>");
> +    document.write("margin-bottom: " + window.getComputedStyle(foodiv,
null).getPropertyValue("margin-bottom"));
> +    document.write( "<br>");
> +    document.write("padding-left: " + window.getComputedStyle(foodiv,
null).getPropertyValue("padding-left"));
> +    document.write( "<br>");
> +    document.write("left: " + window.getComputedStyle(foodiv,
null).getPropertyValue("left"));
> +    document.write( "<br>");

Please look at how script tests are done
(/Tools/Scripts/make-script-test-wrappers and examples in
fast/css/script-tests).

document.write is evil.


More information about the webkit-reviews mailing list