[webkit-reviews] review requested: [Bug 34285] [Gtk] Password field doesn't get input method : [Attachment 82130] Allow input methods in password input elements, #2

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at twotoasts.de> has asked  for review:
Bug 34285: [Gtk] Password field doesn't get input method
https://bugs.webkit.org/show_bug.cgi?id=34285

Attachment 82130: Allow input methods in password input elements, #2
https://bugs.webkit.org/attachment.cgi?id=82130&action=review

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
(In reply to comment #7)
> #if PLATFORM(MAC)
>     // Platform convention is to only allow Roman characters in passwords.

This is not just about non-Latin characters, but also virtual keyboards, thusly
I made it:

// Platform convention is to disallow input methods for passwords.

> I would really prefer a deeper refactoring that wouldn't leave us with Gtk
specific code in HTMLInputElement.

I don't have a Mac and I'm probably not a good person to judge how it would
need to be changed. From a quick look I didn't even see password handling at
all, so I assume it relies on system behaviour to a good extend.

> +    // Arguably insecure. In practise required if the password must be
> 
> We normally use American spelling in WebKit (i.e. "practice").

Corrected.