[webkit-reviews] review granted: [Bug 54227] Web Inspector: make InspectorAgent own sub-agents, align agent creation/deletion routines. : [Attachment 82129] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 11 06:47:45 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 54227: Web Inspector: make InspectorAgent own sub-agents, align agent
creation/deletion routines.
https://bugs.webkit.org/show_bug.cgi?id=54227

Attachment 82129: Patch
https://bugs.webkit.org/attachment.cgi?id=82129&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=82129&action=review

> Source/WebCore/inspector/InspectorDatabaseAgent.h:45
> +    class FrontendProvider : public RefCounted<FrontendProvider> {

No need to define this class in the public part of the agent. You can just put
forward declaration here and define the class in .cpp.


More information about the webkit-reviews mailing list