[webkit-reviews] review requested: [Bug 38634] [Qt] QWebFrame::setHtml doesn't emit loadFinished signal : [Attachment 81881] patch to check loadFinished signal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 9 15:05:50 PST 2011


kasthuri <kasthuri.n-s at nokia.com> has asked  for review:
Bug 38634: [Qt] QWebFrame::setHtml doesn't emit loadFinished signal
https://bugs.webkit.org/show_bug.cgi?id=38634

Attachment 81881: patch to check loadFinished signal
https://bugs.webkit.org/attachment.cgi?id=81881&action=review

------- Additional Comments from kasthuri <kasthuri.n-s at nokia.com>
The proposed test modification was connecting for the loadFinished signal after
calling setHtml() api which resulted in missing the signal for simple html
files.
Hence the test was failing.  Updated the test to check for the loadFinished
signal using QSignalSpy.


More information about the webkit-reviews mailing list