[webkit-reviews] review granted: [Bug 54083] Add WTF::cryptographicallyRandomNumber : [Attachment 81845] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 54083: Add WTF::cryptographicallyRandomNumber
https://bugs.webkit.org/show_bug.cgi?id=54083

Attachment 81845: Patch
https://bugs.webkit.org/attachment.cgi?id=81845&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81845&action=review

Looks good.  Thanks for all the cleanup!

> Source/JavaScriptCore/wtf/CryptographicallyRandomNumber.cpp:164
> +	   stirIfNeeded();

I would have just put all the stirIfNeeded and count stuff in getByte and
bumped the initial m_count up by how much one is supposed to disgard at the
beginning (or just reset the m_count after the initial discard).  But this is
OK.