[webkit-reviews] review denied: [Bug 54098] Web Inspector: [regression] Fix syncing heights of the gutter and main panel lines, and add 2px padding-left : [Attachment 81803] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 9 07:08:53 PST 2011
Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at google.com>'s request for review:
Bug 54098: Web Inspector: [regression] Fix syncing heights of the gutter and
main panel lines, and add 2px padding-left
https://bugs.webkit.org/show_bug.cgi?id=54098
Attachment 81803: Patch
https://bugs.webkit.org/attachment.cgi?id=81803&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81803&action=review
> Source/WebCore/inspector/front-end/TextViewer.js:166
> + gutterChunk.element.style.height = "";
I am not sure what setting integer property to "" is supposed to do. You should
use setProperty and removeProperty on style object instead.
More information about the webkit-reviews
mailing list