[webkit-reviews] review denied: [Bug 54100] Web Inspector: InspectorAgent should know nothing about InspectorController instance. : [Attachment 81804] [patch] initial version

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 54100: Web Inspector: InspectorAgent should know nothing about
InspectorController instance.
https://bugs.webkit.org/show_bug.cgi?id=54100

Attachment 81804: [patch] initial version
https://bugs.webkit.org/attachment.cgi?id=81804&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81804&action=review

> Source/WebCore/inspector/InspectorAgent.cpp:202
> +    m_domAgent->setDocument(m_inspectedPage->mainFrame()->document());

While you are here, please nuke setDocument call here - it is done from within
pushDataCollectedOffline.

> Source/WebCore/inspector/InspectorController.cpp:117
> +    m_inspectorAgent->disconnectFrontend();

InspectorAgent::disconnectFrontend is manipulating front-end. Hence it should
be called before the m_inspectorFrontend.clear() above.

> Source/WebCore/inspector/InspectorController.cpp:146
> +    if (!m_inspectorFrontend)

Now that you know that front-end does not exist, why checking for
m_inspectorFrontend here?