[webkit-reviews] review granted: [Bug 53838] nrwt multiprocessing: move code from dump_render_tree_thread to single_test_runner : [Attachment 81589] update w/ tony's review feedback
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 8 09:42:31 PST 2011
Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53838: nrwt multiprocessing: move code from dump_render_tree_thread to
single_test_runner
https://bugs.webkit.org/show_bug.cgi?id=53838
Attachment 81589: update w/ tony's review feedback
https://bugs.webkit.org/attachment.cgi?id=81589&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
(In reply to comment #3)
> I'm not sure that anyone actually looks at these files normally, so it may be
best to just remove it, but I'll post that as a separate change. Generally
speaking, I think NRWT logs more stuff in more places than it should and I'd
like to remove some things and rationalize others. But that's a thought for a
different thread.
Is the file used for anything? If not, I agree that we should remove it in a
follow up patch. Seems like it could be reconstructed from the output as the
script is run.
More information about the webkit-reviews
mailing list