[webkit-reviews] review granted: [Bug 36202] popstate event should be dispatched asynchronously : [Attachment 81647] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 36202: popstate event should be dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=36202

Attachment 81647: Patch
https://bugs.webkit.org/attachment.cgi?id=81647&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81647&action=review

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:-1548
> -	   // We can arrive here if a popstate event handler detaches this
frame.

To test this, I think you'd need to modify the NPAPI test plugin.  This patch
actually fixes the bug where we would fail to notify a plugin of when a frame
finishes navigating.

You could have a test, where a plugin uses NPN_GetURLNotify w/ target equal to
the name of a frame.  It expects to receive a NPP_URLNotify call once the frame

navigation completes.

I'm not sure if TestNetscapePlugin has any tests like this already.