[webkit-reviews] review granted: [Bug 53902] JSVariableObject::setRegisters should take PassOwnArrayPtr for registersArray. : [Attachment 81449] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 53902: JSVariableObject::setRegisters should take PassOwnArrayPtr for
registersArray.
https://bugs.webkit.org/show_bug.cgi?id=53902

Attachment 81449: Patch
https://bugs.webkit.org/attachment.cgi?id=81449&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81449&action=review

> Source/JavaScriptCore/runtime/JSVariableObject.h:162
> +	   ASSERT(registerArray.get() != d->registerArray.get());

I’m surprised that either get() is required. We should make the smart pointers
work for equality comparison without using the get().