[webkit-reviews] review granted: [Bug 53842] WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles : [Attachment 81448] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 7 08:14:59 PST 2011


Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 53842: WAI-ARIA @aria-sort not exposed on rowheader and columnheader roles
https://bugs.webkit.org/show_bug.cgi?id=53842

Attachment 81448: Patch
https://bugs.webkit.org/attachment.cgi?id=81448&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81448&action=review

> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:1990
> +	   switch (m_object->sortDirection()) {
> +	       case SortDirectionAscending:
> +		   return NSAccessibilityAscendingSortDirectionValue;
> +	       case SortDirectionDescending:
> +		   return NSAccessibilityDescendingSortDirectionValue;
> +	       default:
> +		   return NSAccessibilityUnknownSortDirectionValue;
> +	   }

WebKit style doesn't indent the case inside the switch.


More information about the webkit-reviews mailing list