[webkit-reviews] review granted: [Bug 53690] IndexedDB: Cursors should skip deleted entries : [Attachment 81226] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 53690: IndexedDB: Cursors should skip deleted entries
https://bugs.webkit.org/show_bug.cgi?id=53690

Attachment 81226: Patch
https://bugs.webkit.org/attachment.cgi?id=81226&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81226&action=review

This test should also verify that anything not deleted is seen while iterating.
 r=me assuming you do that.

> LayoutTests/storage/indexeddb/cursor-skip-deleted.html:61
> +    resetObjectStore(); // No callback; let the setVersion transaction
complete.

Seems cleaner to pass in an empty function here...you probably don't even need
a comment then.

> LayoutTests/storage/indexeddb/cursor-skip-deleted.html:140
> +		      {id: 15, targets: [13,14]}

while you're at it, might as well throw a few more interesting combinations in.
 :-)

> LayoutTests/storage/indexeddb/cursor-skip-deleted.html:169
> +    testCursor(deletes,
"trans.objectStore('store').index('nameIndex').openCursor(webkitIDBKeyRange.low
erBound('Alpha'))", function() { resetObjectStore(); });

why do a final reset?