[webkit-reviews] review denied: [Bug 51013] [Chromium] Should implement EditorClientImpl::requestCheckingOfString() : [Attachment 81182] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 51013: [Chromium] Should implement
EditorClientImpl::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=51013

Attachment 81182: Patch
https://bugs.webkit.org/attachment.cgi?id=81182&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81182&action=review

> Source/WebKit/chromium/public/WebTextCheckingCompletion.h:35
> +#include "WebTextCheckingResult.h"

nit: i think you can just forward declare WebTextCheckingResult and WebVector
here instead.

> Source/WebKit/chromium/public/WebTextCheckingResult.h:35
> +#include "WebVector.h"

nit: no need for WebVector include here

> Tools/DumpRenderTree/chromium/WebViewHost.cpp:232
> +    WebViewHost* wvh = static_cast<WebViewHost*>(context);

how do you know that the WebViewHost hasn't been deleted by the time this
function is called?