[webkit-reviews] review granted: [Bug 74952] Need AssociatedURLLoader tests for redirects and CORS access control : [Attachment 120231] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Bill Budge <bbudge at gmail.com>'s
request for review:
Bug 74952: Need AssociatedURLLoader tests for redirects and CORS access control
https://bugs.webkit.org/show_bug.cgi?id=74952

Attachment 120231: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=120231&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120231&action=review


> Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp:-126
> -	   EXPECT_EQ(m_expectedRedirectResponse.mimeType(),
redirectResponse.mimeType());

I thought you were going to leave this in?

> Source/WebKit/chromium/tests/AssociatedURLLoaderTest.cpp:177
> +	   if (m_runningMessageLoop) {
> +	     m_runningMessageLoop = false;
> +	     webkit_support::QuitMessageLoop();
> +	   }

Bad indent.