[webkit-reviews] review granted: [Bug 75049] [filesystem/Chromium] filesystem URLs are not fully supported : [Attachment 120229] Small plumbing changes; the real work's done in googleURL and the Chromium codebase.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 75049: [filesystem/Chromium] filesystem URLs are not fully supported
https://bugs.webkit.org/show_bug.cgi?id=75049

Attachment 120229: Small plumbing changes; the real work's done in googleURL
and the Chromium codebase.
https://bugs.webkit.org/attachment.cgi?id=120229&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120229&action=review


> Source/WebCore/page/SecurityOrigin.cpp:85
> +#if ENABLE(FILE_SYSTEM)

This shouldn't be guarded with ENABLE(FILE_SYSTEM).  It has nothing to do with
FILE_SYSTEM.

> Source/WebCore/platform/KURL.h:226
> +#if ENABLE(FILE_SYSTEM)

This shouldn't be guarded with ENABLE(FILE_SYSTEM).  It has nothing to do with
FILE_SYSTEM.

> Source/WebCore/platform/KURLGoogle.cpp:292
> +void KURLGooglePrivate::initInnerURL() {

{ should be on the next line.

> Source/WebCore/platform/KURLGoogle.cpp:337
> +    if (m_innerURL) {
> +	 dest->m_innerURL = adoptPtr(new KURL(m_innerURL->copy()));
> +    }
> +    else
> +	 dest->m_innerURL.clear();

Bad indent and we can drop the { }