[webkit-reviews] review granted: [Bug 74979] Add CMake option to only build JavaScriptCore : [Attachment 120121] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 74979: Add CMake option to only build JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=74979

Attachment 120121: Patch
https://bugs.webkit.org/attachment.cgi?id=120121&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=120121&action=review


LGTM, please fix the default value thing before landing.

> CMakeLists.txt:15
> +    SET(ENABLE_WEBCORE On)

Better to give ENABLE_WEBCORE the default value on.