[webkit-reviews] review granted: [Bug 74998] Change the item type of Document::m_formElementsWithState from Element* to HTMLFormControlElementWithState* : [Attachment 120155] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 74998: Change the item type of Document::m_formElementsWithState from
Element* to HTMLFormControlElementWithState*
https://bugs.webkit.org/show_bug.cgi?id=74998

Attachment 120155: Patch
https://bugs.webkit.org/attachment.cgi?id=120155&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120155&action=review


Love it!

> Source/WebCore/dom/Document.cpp:4319
>	   String value;
>	   if (!elementWithState->shouldSaveAndRestoreFormControlState())
>	       continue;

Unrelated to this patch, but we should move "String value;" below the continue
to avoid creating the empty string unnecessarily.