[webkit-reviews] review denied: [Bug 71559] [Qt] QWebPreferences are leaking to other WebViews : [Attachment 119039] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 71559: [Qt] QWebPreferences are leaking to other WebViews
https://bugs.webkit.org/show_bug.cgi?id=71559

Attachment 119039: Patch
https://bugs.webkit.org/attachment.cgi?id=119039&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119039&action=review


Looks good, but needs a rebase :)

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:69
> +    if (!pageGroupRef)
> +	   pageGroupRef = toAPI(WebPageGroup::create().leakRef());

I think that's okay, but this patch is going to need a rebase, and that will
make it nicer :) . I suspect that after a rebase the code will look like this:

RefPtr<WebPageGroup> pageGroup;
if (pageGroupRef)
    pageGroup = toImpl(pageGroupRef);
else
    pageGroup = WebPageGroup::create();

... foo(pageGroup.get());