[webkit-reviews] review granted: [Bug 74825] We don't pass all of the html5lib unsafe-text.dat tests : [Attachment 119783] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 74825: We don't pass all of the html5lib unsafe-text.dat tests
https://bugs.webkit.org/show_bug.cgi?id=74825

Attachment 119783: Patch
https://bugs.webkit.org/attachment.cgi?id=119783&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119783&action=review


>>> Source/WebCore/ChangeLog:24
>>> +		 - We're supposed to replace NUL characters if the next
character
>> 
>> if the next?
> 
> Yeah, this setting on the tokenizer affects future tokens.

Sure, but the sentence makes no sense.

>>> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2821
>>> +	     if (m_framesetOk &&
!isAllWhitespaceOrReplacementCharacters(characters))
>> 
>> Seems this subtly may need a comment.
> 
> I'm happy to add a comment.  I'm not sure what it would say other than to
look at a specific line in the spec.  There's a test, which seems like the
important thing.

If the spec mentions replacemnt characters here then that's fine. :)