[webkit-reviews] review denied: [Bug 74603] Web Inspector: Implement CSS selector profiler backend : [Attachment 119852] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 74603: Web Inspector: Implement CSS selector profiler backend
https://bugs.webkit.org/show_bug.cgi?id=74603

Attachment 119852: Patch
https://bugs.webkit.org/attachment.cgi?id=119852&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119852&action=review


> Source/WebCore/inspector/InspectorCSSAgent.cpp:151
> +	   : totalTime(0.0), hits(0), matches(0)

m_totalTime, m_hits, m_matches

> Source/WebCore/inspector/InspectorCSSAgent.cpp:163
> +class SelectorProfile : public RefCounted<SelectorProfile> {

Why is this ref-counted?

> Source/WebCore/inspector/InspectorCSSAgent.cpp:282
> +    , m_recordingSelectorProfile(false)

nuke?

> Source/WebCore/inspector/InspectorCSSAgent.cpp:287
> +    , m_id(1)

nuke?

> Source/WebCore/inspector/InspectorCSSAgent.h:99
> +    int id() const { return m_id; }

You don't need this id.

> Source/WebCore/inspector/InspectorCSSAgent.h:102
> +    struct RuleMatchData {

Can this still be a part of profile?

> Source/WebCore/inspector/InspectorCSSAgent.h:145
> +    bool m_recordingSelectorProfile;

nuke.

> Source/WebCore/inspector/InspectorCSSAgent.h:153
> +    int m_id;

nuke

> Source/WebCore/inspector/InspectorCSSAgent.h:156
> +    RuleMatchData m_currentMatchData;

move to profile