[webkit-reviews] review denied: [Bug 73364] [Qt][WK2] Expose WebContext as an experimental API and move downloadRequested to it : [Attachment 119489] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 19 05:51:25 PST 2011
Simon Hausmann <hausmann at webkit.org> has denied Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 73364: [Qt][WK2] Expose WebContext as an experimental API and move
downloadRequested to it
https://bugs.webkit.org/show_bug.cgi?id=73364
Attachment 119489: Patch
https://bugs.webkit.org/attachment.cgi?id=119489&action=review
------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I don't think this is the way we should expose the context, as just another
property.
I suppose we _could_ make it a separate entity and move our main webview
initialization code to componentComplete(). Then perhaps it would be easier to
support an optional _settable_ context property on the view:
WebView {
id: standaloneView
}
WebContext {
id: myContext
onDownloadRequest: { ...}
}
WebView {
context: myContext
}
WebView {
id: anotherInstance
context: myContext
}
What do you think?
More information about the webkit-reviews
mailing list