[webkit-reviews] review granted: [Bug 74748] Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step : [Attachment 119678] cleanup

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 74748: Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
https://bugs.webkit.org/show_bug.cgi?id=74748

Attachment 119678: cleanup
https://bugs.webkit.org/attachment.cgi?id=119678&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119678&action=review


> Source/WebCore/editing/Editor.cpp:892
> -	      
client()->registerCommandForUndo(toCompositeEditCommand(m_lastEditCommand.get()
)->ensureComposition());
> +	      
client()->registerUndoStep(toCompositeEditCommand(m_lastEditCommand.get())->ens
ureComposition());

If we do this casting often we should have a lastCommandAsComposite() or
similar accessor :)