[webkit-reviews] review granted: [Bug 74753] Add a pretty dumb tile cache to WebTileCacheLayer : [Attachment 119677] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 74753: Add a pretty dumb tile cache to WebTileCacheLayer
https://bugs.webkit.org/show_bug.cgi?id=74753

Attachment 119677: Patch
https://bugs.webkit.org/attachment.cgi?id=119677&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=119677&action=review


> Source/WebCore/platform/graphics/ca/mac/TileCache.h:67
> +    void getTileRangeForRect(const IntRect&, IntPoint& topLeft, IntPoint&
bottomRight);
> +
> +    IntSize numTilesForGridSize(const IntSize&);

Can these be const?

> Source/WebCore/platform/graphics/ca/mac/TileCache.h:70
> +    WebTileLayer* tileLayerAtPosition(const IntPoint&);

Make const?

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:99
> +	   CGContextRestoreGState(context);

Tab here?

> Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.h:34
> +    OwnPtr<WebCore::TileCache> _tileCache;

Do we still do underscores on Obj-C member vars? Is ugly.