[webkit-reviews] review granted: [Bug 74566] webkitpy: finish refactoring port classes to make a host mandatory : [Attachment 119344] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 14 18:31:11 PST 2011
Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 74566: webkitpy: finish refactoring port classes to make a host mandatory
https://bugs.webkit.org/show_bug.cgi?id=74566
Attachment 119344: Patch
https://bugs.webkit.org/attachment.cgi?id=119344&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119344&action=review
LGTM.
> Tools/Scripts/webkitpy/layout_tests/port/base.py:55
> +from webkitpy.common.system.systemhost_mock import MockSystemHost
I don't think we want to import testing code into production code. I suspect
this import isn't even needed. :)
More information about the webkit-reviews
mailing list