[webkit-reviews] review granted: [Bug 74558] [chromium] DatabaseObserver needs threadsafe fixes and other clean-up. : [Attachment 119324] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 14 18:27:13 PST 2011


Dmitry Titov <dimich at chromium.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 74558: [chromium] DatabaseObserver needs threadsafe fixes and other
clean-up.
https://bugs.webkit.org/show_bug.cgi?id=74558

Attachment 119324: Patch
https://bugs.webkit.org/attachment.cgi?id=119324&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119324&action=review


> Source/WebKit/chromium/src/DatabaseObserver.cpp:90
> +	   m_workerLoaderProxy->postTaskForModeToWorkerContext(

do we follow this style in WebKit or should it be in one long line?

> LayoutTests/http/tests/workers/interrupt-database-sync-open-crash.html:8
> +var workers = new Array(30);

why 30 workers and 10 iterations? Would be nice to add a comment on the number
selection.


More information about the webkit-reviews mailing list