[webkit-reviews] review granted: [Bug 74417] [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock : [Attachment 119177] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Alexander Færøy
<ahf at 0x90.dk>'s request for review:
Bug 74417: [Qt] DeviceOrientationClientMockQt should be removed in favor of
DeviceOrientationClientMock
https://bugs.webkit.org/show_bug.cgi?id=74417

Attachment 119177: Patch
https://bugs.webkit.org/attachment.cgi?id=119177&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119177&action=review


r=me but watch the bot when landing :)

> Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:853
> +    QList<WebCore::WebPage*> pages = m_drt->getAllPages();
> +    foreach (WebCore::WebPage* page, pages)
> +	   DumpRenderTreeSupportQt::setMockDeviceOrientation(page,
canProvideAlpha, alpha, canProvideBeta, beta, canProvideGamma, gamma);

The loop could also be moved into setMockDeviceOrientation.