[webkit-reviews] review granted: [Bug 74337] WebKit code shouldn't be calling applyCommand directly : [Attachment 118851] cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 12 14:41:52 PST 2011

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 74337: WebKit code shouldn't be calling applyCommand directly

Attachment 118851: cleanup

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118851&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2246
> +    bool selectReplacement = true;
> +    bool smartReplace = 0;
> +    return frame->editor()->replaceSelectionWithText(text,
selectReplacement, smartReplace);

We should change this to flags or enums, longer term. Also, we should use false
instead of 0.

More information about the webkit-reviews mailing list