[webkit-reviews] review denied: [Bug 74313] Implement the JavaScriptCore bindings for eventListenerHandlerLocation : [Attachment 118822] amended patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Konrad Piascik
<kpiascik at rim.com>'s request for review:
Bug 74313: Implement the JavaScriptCore bindings for
eventListenerHandlerLocation
https://bugs.webkit.org/show_bug.cgi?id=74313

Attachment 118822: amended patch
https://bugs.webkit.org/attachment.cgi?id=118822&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118822&action=review


> Source/WebCore/bindings/js/ScriptEventListener.cpp:123
> +    sourceName = String(funcExecutable->sourceURL().characters());

funcExecutable->sourceURL() is a UString. The preferred way to convert
JSC::UString to WTF::String is to call ustringToString(), which will avoid a
copy.