[webkit-reviews] review granted: [Bug 74298] Web Inspector: report per document JS event listener count : [Attachment 118802] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 74298: Web Inspector: report per document JS event listener count
https://bugs.webkit.org/show_bug.cgi?id=74298

Attachment 118802: Patch
https://bugs.webkit.org/attachment.cgi?id=118802&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118802&action=review


> Source/WebCore/inspector/InspectorMemoryAgent.cpp:114
> +	   EventListenerIterator iterator(node);

similarly to the nameToCount you could introduce eventTypeToCount here and use
return by-type stats (as in InspectorDOMAgent:742)

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:117
> +		   result++;

++result;