[webkit-reviews] review denied: [Bug 69972] Spurious warnings when receiving HTTP response code 204 : [Attachment 118637] ChangeLog now contains bug number.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 11 09:34:43 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied rodarmor at google.com's request
for review:
Bug 69972: Spurious warnings when receiving HTTP response code 204
https://bugs.webkit.org/show_bug.cgi?id=69972

Attachment 118637: ChangeLog now contains bug number.
https://bugs.webkit.org/attachment.cgi?id=118637&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118637&action=review


> Source/WebCore/inspector/front-end/NetworkManager.js:155
> +	       || resource.statusCode === 204

I don't think this is specific to the 204. This check is basically testing
whether the mime type returned with the HTTP response is consistent with the
type WebKit assigned to the loaded resource. The actual bug is in line 142
above that prints this.type and this.mimeType instead of resource.type and
resource.mimeType. Fixing it will uncover whether 204 needs special handling.


More information about the webkit-reviews mailing list