[webkit-reviews] review denied: [Bug 74238] Unify inspectors preprocessor statements : [Attachment 118692] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 11 09:26:17 PST 2011

Pavel Feldman <pfeldman at chromium.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 74238: Unify inspectors preprocessor statements

Attachment 118692: Patch

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118692&action=review

> Source/WebCore/inspector/ConsoleMessage.h:34

Here and below: I don't think we should guard header private to inspector:
including them from outside of inspector should break !ENABLE(INSPECTOR)
configurations and hence point to the problem. I'd rather go through inspector
internals and wipe out similar guards from headers there.

More information about the webkit-reviews mailing list