[webkit-reviews] review denied: [Bug 74238] Unify inspectors preprocessor statements : [Attachment 118692] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 74238: Unify inspectors preprocessor statements
https://bugs.webkit.org/show_bug.cgi?id=74238

Attachment 118692: Patch
https://bugs.webkit.org/attachment.cgi?id=118692&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118692&action=review


> Source/WebCore/inspector/ConsoleMessage.h:34
> +#if ENABLE(INSPECTOR)

Here and below: I don't think we should guard header private to inspector:
including them from outside of inspector should break !ENABLE(INSPECTOR)
configurations and hence point to the problem. I'd rather go through inspector
internals and wipe out similar guards from headers there.