[webkit-reviews] review denied: [Bug 74088] Web Inspector: auto detect source map url. : [Attachment 118571] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 9 07:06:25 PST 2011

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 74088: Web Inspector: auto detect source map url.

Attachment 118571: Patch

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118571&action=review

> Source/WebCore/ChangeLog:8
> +	   Check to see if "X-SourceMap" HTTP response header was sent with
script resource.

Is there a discussion on the X-SourceMap name?

> Source/WebCore/inspector/Inspector.json:1994
> +		       { "name": "sourceMapURL", "type": "string",
"description": "URL of source map associated with script (if any)." },

We should not process sourceMapURL on the backend (node.js won't have it). User
should listen to the network and get it from there.

More information about the webkit-reviews mailing list