[webkit-reviews] review denied: [Bug 74169] Upstream 3 files into WebCore/platform/blackberry : [Attachment 118553] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Mary Wu <mary.wu at torchmobile.com.cn>'s
request for review:
Bug 74169: Upstream 3 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74169

Attachment 118553: Patch
https://bugs.webkit.org/attachment.cgi?id=118553&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118553&action=review


Mostly just some nits left.

> Source/WebCore/platform/blackberry/GeolocationServiceBlackBerry.cpp:106
> +							     true, //
providesAltititude

providesAltititude?

> Source/WebCore/platform/blackberry/GeolocationServiceBlackBerry.cpp:112
> +							     0.0, // heading

0.0 -> 0

> Source/WebCore/platform/blackberry/GeolocationServiceBlackBerry.cpp:114
> +							     0.0); // speed

0.0 -> 0

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:45
> +    virtual void setPreventsScreenDimming(bool preventDimming) = 0;

preventDimming is obvious, can be removed.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:46
> +    virtual void showVirtualKeyboard(bool showKeyboard) = 0;

showKeyboard is obvious, can be removed.

> Source/WebCore/platform/blackberry/PageClientBlackBerry.h:61
> +    virtual int showAlertDialog(BlackBerry::WebKit::WebPageClient::AlertType
atype) = 0;

Remove atype