[webkit-reviews] review granted: [Bug 73821] keyboard event doesn't fire while moving mouse with button pressed : [Attachment 118175] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 8 17:20:20 PST 2011


Alexey Proskuryakov <ap at webkit.org> has granted Rakesh
<rakesh.kn at motorola.com>'s request for review:
Bug 73821: keyboard event doesn't fire while moving mouse with button pressed
https://bugs.webkit.org/show_bug.cgi?id=73821

Attachment 118175: Updated patch
https://bugs.webkit.org/attachment.cgi?id=118175&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Talked on IRC, and I had some confusion about this patch. Posting the
explanation here for posterity.

The fix does more than the original description asked for - in addition to
making the event fire (which could be achieved by avoiding an early return), it
fixes a user visible issue where autoscrolling stopped if a key was pressed.

Both new behaviors seem to match IE9 in my testing.


More information about the webkit-reviews mailing list