[webkit-reviews] review denied: [Bug 72281] Fix find on web pages with -webkit-user-select: none for Chromium : [Attachment 118066] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 8 17:19:26 PST 2011


Ryosuke Niwa <rniwa at webkit.org> has denied Martin Kosiba
<mkosiba at chromium.org>'s request for review:
Bug 72281: Fix find on web pages with -webkit-user-select: none for Chromium
https://bugs.webkit.org/show_bug.cgi?id=72281

Attachment 118066: Patch
https://bugs.webkit.org/attachment.cgi?id=118066&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118066&action=review


r- due to various nits.

> Source/WebCore/editing/Editor.cpp:2785
> +   
nextMatch->firstNode()->renderer()->enclosingLayer()->scrollRectToVisible(
> +	   nextMatch->boundingBox(),
> +	   ScrollAlignment::alignCenterIfNeeded,
> +	   ScrollAlignment::alignCenterIfNeeded);

We don't line break per argument. WebKit style is to do:
   
nextMatch->firstNode()->renderer()->enclosingLayer()->scrollRectToVisible(nextM
atch->boundingBox(),
	ScrollAlignment::alignCenterIfNeeded,
ScrollAlignment::alignCenterIfNeeded);

>> Source/WebKit/chromium/src/WebFrameImpl.cpp:1526
>> +	} else {
>> +	    setMarkerActive(m_activeMatch.get(), false);
>> +	}
> 
> One line control clauses should not use braces.  [whitespace/braces] [4]

As style bot pointed out, you shouldn't have { } around a single-line
statement.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1542
> +	       | (options.matchCase ? 0 : CaseInsensitive)
> +	       | (wrapWithinFrame ? WrapAround : 0)
> +	       | (!options.findNext ? StartInSelection : 0);

These lines are indented too much. | should appear exactly 4 spaces to the
right of const.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1565
> +		   m_activeMatchIndexInActiveMatchFrame = 0;

I don't think "InActiveMatchFrame" is helpful. It's probably better to say
m_activeMatchIndexInCurrentFrame and rename m_activeMatchFrame to
m_currentActiveMatchFrame.


More information about the webkit-reviews mailing list