[webkit-reviews] review denied: [Bug 74004] Web Inspector: Implement CSS selector profiler : [Attachment 118221] [PATCH] Fix Mac compilability

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 7 10:16:01 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 74004: Web Inspector: Implement CSS selector profiler
https://bugs.webkit.org/show_bug.cgi?id=74004

Attachment 118221: [PATCH] Fix Mac compilability
https://bugs.webkit.org/attachment.cgi?id=118221&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Before we introduce a new capability / perspective / functionality, it would be
great to figure out what it measures and whether it is useful to the end users.
I can see selector matching taking single digit milliseconds. I know from the
timeline panel that layout takes hundres of milliseconds or even seconds.

I don't think we should expose this type of profiling, but should rather figure
out how to help developers to figure out why layout is so slow. I am putting r-
here unless we figure out whether we need this type of profile.


More information about the webkit-reviews mailing list