[webkit-reviews] review granted: [Bug 70556] [Chromium] Plumb DPI info into PlatformScreen : [Attachment 118148] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 70556: [Chromium] Plumb DPI info into PlatformScreen
https://bugs.webkit.org/show_bug.cgi?id=70556

Attachment 118148: Patch
https://bugs.webkit.org/attachment.cgi?id=118148&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118148&action=review


> Source/WebCore/platform/PlatformScreen.h:50
> +    int screenHorizontalDPI(Widget*);

maybe PlatformScreen functions should also return 'unsigned'?  why be
different?  i'm guessing you were going for consistency.  hmm...

> Source/WebKit/chromium/src/mac/WebScreenInfoFactory.mm:85
> +    results.horizontalDPI = (int)deviceDPI.width;

shouldn't this use C++ style casts?