[webkit-reviews] review denied: [Bug 71968] Implement URL API : [Attachment 118024] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 10:33:26 PST 2011

Erik Arvidsson <arv at chromium.org> has denied Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 71968: Implement URL API

Attachment 118024: Patch

------- Additional Comments from Erik Arvidsson <arv at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=118024&action=review

> Source/WebCore/html/DOMURL.idl:59
> -	   [ConvertNullStringTo=Undefined] DOMString createObjectURL(in
MediaStream stream);
> +	   [Conditional=BLOB] static DOMString createObjectURL(in MediaStream
>  #endif
> -	   [ConvertNullStringTo=Undefined] DOMString createObjectURL(in Blob
> -	   void revokeObjectURL(in DOMString url);
> +	   [Conditional=BLOB] static DOMString createObjectURL(in Blob blob);
> +	   static [Conditional=BLOB] void revokeObjectURL(in DOMString url);

These needs to be 

static [Conditional=BLOB] type name(params);

However, beware that you will need to keep the #if here since overloaded
methods cannot have different Conditional. Maybe a comment is due?

More information about the webkit-reviews mailing list