[webkit-reviews] review granted: [Bug 73928] Put length in its own variable in KURL copyASCII : [Attachment 118063] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 6 10:13:55 PST 2011


Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 73928: Put length in its own variable in KURL copyASCII
https://bugs.webkit.org/show_bug.cgi?id=73928

Attachment 118063: Patch
https://bugs.webkit.org/attachment.cgi?id=118063&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118063&action=review


> Source/WebCore/platform/KURL.cpp:267
> +	   const size_t length = string.length();

Please remove the const (or you could make src also const and build a bicycle
shed).


More information about the webkit-reviews mailing list