[webkit-reviews] review denied: [Bug 73817] [TexMap][QT] TexMap does not draw the border of media and webgl elements. : [Attachment 117958] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 73817: [TexMap][QT] TexMap does not draw the border of media and webgl
elements.
https://bugs.webkit.org/show_bug.cgi?id=73817

Attachment 117958: patch
https://bugs.webkit.org/attachment.cgi?id=117958&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117958&action=review


> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:307
> +    if (m_currentContent.contentType == MediaContentType &&
!m_currentContent.needsDisplay) {
> +	   m_currentContent.needsDisplayContents = false;
>	   return;
> +    }
> +    if (m_currentContent.contentType != MediaContentType) {
> +	   m_currentContent.needsDisplay =
m_currentContent.needsDisplayContents;
> +	   m_currentContent.needsDisplayContents = false;
> +    }

This is very hard to read. I think you want a temporary variable here instead
of modifying m_currentContent.needsDisplay.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:123
> +	   bool needsDisplayContents;

contentsNeedsDisplay