[webkit-reviews] review denied: [Bug 73817] [TexMap][QT] TexMap does not draw the border of media and webgl elements. : [Attachment 117955] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied  review:
Bug 73817: [TexMap][QT] TexMap does not draw the border of media and webgl
elements.
https://bugs.webkit.org/show_bug.cgi?id=73817

Attachment 117955: patch
https://bugs.webkit.org/attachment.cgi?id=117955&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117955&action=review


> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:72
> +    m_pendingContent.needsDisplayContents = true;

contentsNeedDisplay instead of needsDisplayContents

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:303
> +    }

This is incorrect.
If content type is not media, we shouldn't use contentsNeedsDisplay at all!

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:123
> +	   bool needsDisplayContents;

contentsNeedDisplay